Bump netlify/next runtime and fix api routes in middleware #13040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pettinarip
requested review from
wackerow,
corwintines,
minimalsm and
nhsz
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pettinarip
commented
May 27, 2024
pettinarip
changed the title
…edirect loop with some nested pages
github-actions
bot
added
config ⚙️
pettinarip
changed the title
pettinarip
commented
Jun 11, 2024
| @@ -48,7 +51,7 @@ export async function middleware(req: NextRequest) { | |||
| const localeDetected = detectLocale(req.headers.get("accept-language")) | |||
| const locale = localeDetected || DEFAULT_LOCALE | |||
|
|
|||
| const redirectUrl = new URL(`/${locale}${pathname}`, req.url) | |||
| const redirectUrl = new URL(`/${locale}${pathname}${search}`, req.url) | |||
There was a problem hiding this comment.
Adding the search params to the redirect, thing that was missing.
wackerow
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Things done in this PR:
@netlify/plugin-nextjsto the latest, v5included_filesfromnetlify.tomldoesn't seem to work, we excluded the heavy files from Netlify function bundles in thenext.config.jsfile/apiroutes from middlewareBonus:
This also fix the issue we currently have when navigating to the home page by using the eth logo on the navbar where it was doing a full page nav instead of a client side one.